Skip to content

Add Edit command to navigate from outline to specific entries in .cproject.yaml#141

Merged
mguzmanm merged 6 commits into
mainfrom
ow_edit_feature
Apr 1, 2026
Merged

Add Edit command to navigate from outline to specific entries in .cproject.yaml#141
mguzmanm merged 6 commits into
mainfrom
ow_edit_feature

Conversation

@mguzmanm
Copy link
Copy Markdown
Contributor

@mguzmanm mguzmanm commented Mar 30, 2026

Fixes

Changes

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@mguzmanm mguzmanm requested a review from Copilot March 30, 2026 12:09
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 30, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 04af875.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new “Edit” command to the Solution Outline context menu to navigate directly to the corresponding group / file entry inside the originating .cproject.yml/.yaml (or layer file), supporting faster editing from the outline view.

Changes:

  • Introduces EditCommand to locate YAML nodes (group/file) and open the source document at the matching offset.
  • Wires the new command into extension activation and contributes it to the outline context menu in package.json.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/views/solution-outline/commands/open-command.ts Updates project-file open behavior to focus the editor on the project: line.
src/views/solution-outline/commands/edit-command.ts New command: opens the originating YAML file at the selected group/file node.
src/views/solution-outline/commands/edit-command.test.ts Adds unit tests for EditCommand navigation behavior.
src/desktop/extension.ts Registers and activates the new EditCommand.
package.json Contributes cmsis-csolution.edit and adds it to the Solution Outline context menu.

Comment thread src/views/solution-outline/commands/open-command.ts Outdated
Comment thread package.json Outdated
@mguzmanm mguzmanm marked this pull request as draft March 30, 2026 12:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comment thread src/views/solution-outline/commands/edit-command.ts
@mguzmanm mguzmanm marked this pull request as ready for review March 30, 2026 14:23
@mguzmanm mguzmanm requested review from edriouk and removed request for edriouk March 30, 2026 14:24
@mguzmanm mguzmanm marked this pull request as draft March 31, 2026 09:06
Comment thread src/views/solution-outline/commands/edit-command.test.ts Outdated
Comment thread src/views/solution-outline/commands/edit-command.test.ts Outdated
@qltysh
Copy link
Copy Markdown

qltysh Bot commented Mar 31, 2026

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.01%.

Modified Files with Diff Coverage (2)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
...ution-outline/tree-structure/solution-outline-project-items.ts100.0%
New file Coverage rating: B
src/views/solution-outline/commands/edit-command.ts84.4%45, 55, 66, 93, 99...
Total85.7%
🤖 Increase coverage with AI coding...

In the `ow_edit_feature` branch, add test coverage for this new code:

- `src/views/solution-outline/commands/edit-command.ts` -- Lines 45, 55, 66, 93, 99, 104, 122, 127, 133, 150, 155, and 161

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@mguzmanm mguzmanm requested a review from edriouk April 1, 2026 07:57
@mguzmanm mguzmanm marked this pull request as ready for review April 1, 2026 08:20
Copy link
Copy Markdown
Collaborator

@edriouk edriouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mguzmanm mguzmanm merged commit 7634898 into main Apr 1, 2026
12 checks passed
@mguzmanm mguzmanm deleted the ow_edit_feature branch April 1, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants